Fix string decoder example in 1.5 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry but this must be a wrong email some how?
…-Juho
On Tue, 7 Apr 2020, 08:20 Kashyap Patel, ***@***.***> wrote:
Hi, I recently started your course on advanced nodejs on plural sight and
noticed that String Decoder example for Chapter 1, lecture 5 is broken
after process stdin changes.
Tested on LTS Node 12
------------------------------
You can view, comment on, or merge this pull request online at:
#2
Commit Summary
- Fix string decoder example in 1.5
File Changes
- *M* 1.5/StringDecoder.js
<https://github.com/jscomplete/advanced-nodejs/pull/2/files#diff-36b974db5d117a93a300882334f2e925>
(10)
Patch Links:
- https://github.com/jscomplete/advanced-nodejs/pull/2.patch
- https://github.com/jscomplete/advanced-nodejs/pull/2.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLM2ALN4X24NLC4TZ7QZSLRLKZ25ANCNFSM4MC2E2VA>
.
|
|
Is this not maintained by Samer Buna? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I recently started your course on advanced nodejs on plural sight and noticed that String Decoder example for Chapter 1, lecture 5 is broken after process stdin changes.
Tested on LTS Node 12